Refactor reassembler unit tests
Open
area: networking
type: enhancement
- Dominant language
- Go
- Stars
- 19.3k
- Forks
- 2k
- Avg merge
- 3d 5h
- Merged PRs (30d)
- 264
Description
Unit testing for the reassembler.go code is testing the private API. Consider refactoring the test to work with the `process()`function instead.
Or maybe even better, refactor reassembler.go into its own package, to clearly hide `updateHoles()` function from the fragmentation package, and only expose `process()` and `checkDoneOrMark()`.
Contributor guide
Assessment
This issue has not been assessed yet.