google / google/gvisor

IP follow on frags should never generate ICMP errors

Open
#4,058 6 comments 0 reactions 0 assignees View on GitHub
revived
Dominant language
Go
Stars
19.3k
Forks
2k
Avg merge
3d 5h
Merged PRs (30d)
264

Description

The ICMP error generation code can never get fragments at this time but when forwarding is fully implemented then they will potentially reach the ICMP code. The ICMP code should be exclude generating error packets for these frags however there is no way to test this at the moment. The check and tests should be added when there is a path that can deliver frags to the ICMP error code.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.