google / google/gvisor

Don't use umask when calculating new file permissions inherited from a default ACL

Open
#13,688 2 comments 0 reactions 0 assignees View on GitHub
type: enhancement
Dominant language
Go
Stars
19.3k
Forks
2k
Avg merge
3d 5h
Merged PRs (30d)
264

Description

### Description

Linux skips the umask step when inheriting perms from an ACL, doing so in gVisor will require relatively major changes since umask isn't passed along to VFS at all, instead masked into the mode directly at the syscall layer.

### Is this feature related to a specific bug?

_No response_

### Do you have a specific solution in mind?

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by tracing how the syscall layer masks the mode with umask before it reaches VFS, then examine how VFS handles permissions inherited from a default ACL. Compare this flow with Linux behavior; done means default-ACL inheritance no longer applies umask while other permission handling remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, linux
Domain
operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.