google / google/gvisor

sigaltstack wrong assert

Open
#11,692 2 comments 0 reactions 0 assignees View on GitHub
stale-issue type: bug
Dominant language
Go
Stars
19.3k
Forks
2k
Avg merge
3d 5h
Merged PRs (30d)
264

Description

### Description

https://github.com/google/gvisor/blob/master/test/syscalls/linux/sigaltstack.cc#L178

assert `EXPECT_LT(badhandler_low_water_mark, reinterpret_cast(stack.ss_sp) + 2 * SIGSTKSZ)`, but it seems to be that badhandler_low_water_mark can't be greater than `static_cast(stack.ss_sp) + SIGSTKSZ` or `reinterpret_cast(stack_mem.data()) + 2 * SIGSTKSZ`

i'm going to contribute the fix if this true

### Steps to reproduce

_No response_

### runsc version

```shell

```

### docker version (if using docker)

```shell

```

### uname

_No response_

### kubectl (if using Kubernetes)

```shell

```

### repo state (if built from source)

_No response_

### runsc debug logs (if available)

```shell

```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.