google / google/guice

Filter DispatcherType Support on ServletModule

Open
#988 4 comments 1 reaction 0 assignees View on GitHub
Dominant language
Java
Stars
12.7k
Forks
1.7k
Avg merge
11m
Merged PRs (30d)
2

Description

I'm failing to find support for the filter's dispatcher type.
For Instance:

```

SomeFilter
com.acme.SomeFilter

SomeFilter
/*
REQUEST
FORWARD

```

I was expecting to use something like:

```
public class MyServletModule extends ServletModule {
@Override
protected void configureServlets() {
filter("/*").through(SomeFilter.class, DispatcherType.REQUEST, DispatcherType.FORWARD);
// or
filter("/*").through(SomeFilter.class).dispatch(DispatcherType.REQUEST, DispatcherType.FORWARD);
}
}
```

Also, the servlet-name is not supported? see below:

```

SomeFilter
SomeServlet
REQUEST
FORWARD

```

I was expecting to use something like:

```
public class MyServletModule extends ServletModule {
@Override
protected void configureServlets() {
filter(SomeServlet.class).through(SomeFilter.class, DispatcherType.REQUEST, DispatcherType.FORWARD);
// or
filter(SomeServlet.class).through(SomeFilter.class).dispatch(DispatcherType.REQUEST, DispatcherType.FORWARD);
}
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.