google / google/guice

FilterDefinition should wrap the servlet request like ServletDefinition

Open
#807 8 comments 0 reactions 0 assignees View on GitHub
imported
Dominant language
Java
Stars
12.7k
Forks
1.7k
Avg merge
11m
Merged PRs (30d)
2

Description

_From [James.Moger](https://code.google.com/u/116428776452027956920/) on May 22, 2014 23:50:06_

Perhaps that design suggestion is incorrect.

Here is the scenario:

filter("/dir/*).through(MyFilter.class);
serve("/dir/*).with(MyServlet.class);

MyFilter.doFilter(request, response) {
  request.getServletPath() == "/dir/com/google/whatever.java"
  request.getPathInfo() == null
}

MyServlet.doGet(request, response) {
  request.getServletPath() == "/dir"
  request.getPathInfo() == "/com/google/whatever.java"
}

The filter does not get the same wrapped request that the servlet gets which makes it difficult for me to correctly process request info.  Can the filter also receive a Request that is wrapped correctly like the servlet appears to receive?

_Original issue: http://code.google.com/p/google-guice/issues/detail?id=807_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.