google / google/guice

Robot Legs PrivateModule leakage

Open
#805 1 comment 0 reactions 0 assignees View on GitHub
imported
Dominant language
Java
Stars
12.7k
Forks
1.7k
Avg merge
11m
Merged PRs (30d)
2

Description

_From [michael.kralka](https://code.google.com/u/103228773281198884360/) on May 03, 2014 01:15:43_

Description of the issue: When using a PrivateModule (or PrivateBinding) to solve the robot legs problem, the private bindings used to construct a leg appear to leak into the other private bindings if one of the legs lack an binding annotation.

The attached example produces the following output:

left=RobotLegs$Leg`@`17a83597 foot=RobotLegs$Foot`@`245658a3 (righty)
right=RobotLegs$Leg`@`20d547f8 foot=RobotLegs$Foot`@`245658a3 (righty)

(Notice the legs have the same right foot).

If both legs are annotated, this works as expected:

left=RobotLegs$Leg`@`17a83597 foot=RobotLegs$Foot`@`245658a3 (lefty)
right=RobotLegs$Leg`@`20d547f8 foot=RobotLegs$Foot`@`1267fb9f (righty) Steps to reproduce: See attached.

_Original issue: http://code.google.com/p/google-guice/issues/detail?id=805_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.