google / google/guice

Provider<HttpServletRequest> request injects the original request, not the output of the filter chain

Open
#780 0 comments 0 reactions 0 assignees View on GitHub
imported
Dominant language
Java
Stars
12.7k
Forks
1.7k
Avg merge
11m
Merged PRs (30d)
2

Description

_From [mmastrac](https://code.google.com/u/115459243651688775505/) on November 07, 2013 11:53:18_

Description of the issue: When using Provider<HttpServletRequest> injection, the output of the Provider is the original request that was passed into GuiceFilter, not the request that comes out of the filter chain. The end result of this is that wrapped requests provided by filters in the chain are not available to components that are running after the filter chain has completed. Steps to reproduce: 1. Create a class with Provider<HttpServletRequest> as a parameter
2. Filter requests through a filter that wraps the servlet request in some way before handing it off during the chain
3. Observe that the provided HttpServletRequest is not the wrapped version

_Original issue: http://code.google.com/p/google-guice/issues/detail?id=780_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.