google / google/guice

Make guice-servlet more adaptable

Open
#618 14 comments 0 reactions 0 assignees View on GitHub
Extension.Servlet imported Type-Patch
Dominant language
Java
Stars
12.7k
Forks
1.7k
Avg merge
11m
Merged PRs (30d)
2

Description

_From [mcculls](https://code.google.com/u/108081409801028235828/) on March 22, 2011 13:51:37_

We're using guice-servlet in a multi-injector scenario where we want to chain the different filter/servlet pipelines under a single instance of a subclass of GuiceFilter. To get this working without co-locating our custom filter under the same package as GuiceFilter we need to make a couple of visibility changes (including removing final from an injected field).

The attached patch contains the necessary changes, comments welcome :)

**Attachment:** [gist](https://gist.github.com/3ee24f4bbe09cccaaf97)
   _[GUICE_SERVLET_CODE_VISIBILITY.patch](https://gist.githubusercontent.com/gissuebot/3ee24f4bbe09cccaaf97/raw/a3dc264a71e97b9220f8be3e3daedbd444965042/GUICE_SERVLET_CODE_VISIBILITY.patch)_

_Original issue: http://code.google.com/p/google-guice/issues/detail?id=618_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.