google / google/guice

Guice servlet style uri mapping is not compatible with servlet API mappings on suffix wildcard patterns, like in /xxxx/*

Open
#442 4 comments 0 reactions 0 assignees View on GitHub
Extension-Servlet imported
Dominant language
Java
Stars
12.7k
Forks
1.7k
Avg merge
11m
Merged PRs (30d)
2

Description

_From [cihan.uluisik](https://code.google.com/u/106933909282503961323/) on October 29, 2009 10:30:05_

Hi,

In one project we migrated from Pico to Guice, we noticed that Guice does
not match a  url like '/xxxx', if you give  '/xxxx/*' as url pattern to a
filter in a servlet module, whereas Servlet Api mapping does.

The reason is, In ServletStyleUriPatternMatcher '*' character is cut off
from the end of url pattern and then it is checked if the given servlet
path starts with it. To be more specific it checks if  '/xxxx' starts with
'/xxxx/' , which is false. I confirmed it by debugging Guice.

Cihan Uluisik
cihan.uluisik`@`gmail.com

_Original issue: http://code.google.com/p/google-guice/issues/detail?id=442_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.