google / google/guice

Child injectors are unaware of Provisions which can be satisfied by the parent injector

Open
#1,123 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
12.7k
Forks
1.7k
Avg merge
11m
Merged PRs (30d)
2

Description

The following unit tests fail, because when you create a child injector, any provision listeners in the child modules aren't capable of listening to any provisions which can be satisfied by the parent.

This includes JIT bindings and makes it completely impossible to listen for any classes which have no-args constructors with no fields being injected.

It seems to me that a child's provision listeners should still be respected if the child injector is the one being used.

An example can be seen in the following gist:
https://gist.github.com/DarkholmeTenk/f430cf96de70b25b8fd01bc597b23abf

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.