google / google/gts

Uses wrong @typescript-eslint/eslint-plugin version when multiple are installed

Open
#932 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
5.3k
Forks
212
PR merge metrics
No merged PRs in 30d

Description

Hello!
In https://github.com/Maxim-Mazurok/google-api-typings-generator I'm updating dependencies, and running into issue:
`@typescript-eslint/eslint-plugin` is needed by two packages:
- gts - uses v5
- @definitelytyped/dtslint - uses v8

from lock file:
```
"node_modules/gts/node_modules/@typescript-eslint/eslint-plugin": {
"version": "5.62.0",
}
```

However when running `gts` I believe that it's using v8 version of parser, which results in this error:
```
ESLint: 8.57.1

TypeError: services.getTypeAtLocation is not a function
Occurred while linting /home/maxim/google-api-typings-generator/bin/apis-sync-helper.ts:61
Rule: "@typescript-eslint/no-floating-promises"
at isKnownSafePromiseCall (/home/maxim/google-api-typings-generator/node_modules/@typescript-eslint/eslint-plugin/dist/rules/no-floating-promises.js:196:35)
at ExpressionStatement (/home/maxim/google-api-typings-generator/node_modules/@typescript-eslint/eslint-plugin/dist/rules/no-floating-promises.js:121:21)
at ruleErrorHandler (/home/maxim/google-api-typings-generator/node_modules/eslint/lib/linter/linter.js:1076:28)
at /home/maxim/google-api-typings-generator/node_modules/eslint/lib/linter/safe-emitter.js:45:58
at Array.forEach ()
at Object.emit (/home/maxim/google-api-typings-generator/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
at NodeEventGenerator.applySelector (/home/maxim/google-api-typings-generator/node_modules/eslint/lib/linter/node-event-generator.js:297:26)
at NodeEventGenerator.applySelectors (/home/maxim/google-api-typings-generator/node_modules/eslint/lib/linter/node-event-generator.js:326:22)
at NodeEventGenerator.enterNode (/home/maxim/google-api-typings-generator/node_modules/eslint/lib/linter/node-event-generator.js:340:14)
at CodePathAnalyzer.enterNode (/home/maxim/google-api-typings-generator/node_modules/eslint/lib/linter/code-path-analysis/code-path-analyzer.js:803:23)
```

Would be great to ensure that `gts` will use internal dependencies, or declare peer deps.

Cheers!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.