google / google/gts

Should `eqeqeq` ignore nulls?

Open
#733 1 comment 0 reactions 0 assignees View on GitHub
priority: p2 type: bug
Dominant language
TypeScript
Stars
5.3k
Forks
212
PR merge metrics
No merged PRs in 30d

Description

The default value for `eqeqeq` is "[always](https://eslint.org/docs/latest/rules/eqeqeq#always)". I would expect it to ignore nulls as suggested in the [style guide](https://google.github.io/styleguide/tsguide.html#equality-checks).

So this line:

https://github.com/google/gts/blob/78c51a14f3c0e3faf54f87030e6e1cefdf0630dc/.eslintrc.json#L14

Needs to be:

```
"eqeqeq": ["error", "always", {"null": "ignore"}]
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.