google / google/gson

JsonReaderInternalAccess.INSTANCE - ugly design

Open
#708 3 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
24.2k
Forks
4.5k
Avg merge
6d 4h
Merged PRs (30d)
12

Description

I'm looking a way to implement MongoObjectReader - something like JsonTreeReader but use mongodb.BasicDBObject instead of JsonObject. Unfortunally some map type adapters invoke JsonTreeReader.promoteNameToValue or execute some ugly code directly onto JsonReader.

I can't derive from JsonTreeReader since it's final. I can't override promoteNameToValue into other JsonReader descendant since it's introduced into JsonTreeReader.

proposed solution:
1) make AbstractJsonReader to remove JsonTreeReader.UNREADABLE_READER stuff
2) make promoteNameToValue member of AbstractJsonReader
3) mark JsonReaderInternalAccess as obsolete

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.