google / google/gson

Change docs to recommend TypeToken.getParameterized instead of anonymous classes

Open
#1,519 2 comments 2 reactions 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
24.2k
Forks
4.5k
Avg merge
6d 4h
Merged PRs (30d)
12

Description

Currently the documentation recommends creating an anonymous class for `TypeToken`s of generic classes. Some examples (there might be more):
https://github.com/google/gson/blob/63ee47cb642c8018e5cddd639aa2be143220ad4b/gson/src/main/java/com/google/gson/reflect/TypeToken.java#L38
https://github.com/google/gson/blob/63ee47cb642c8018e5cddd639aa2be143220ad4b/gson/src/main/java/com/google/gson/Gson.java#L87
https://github.com/google/gson/blob/63ee47cb642c8018e5cddd639aa2be143220ad4b/UserGuide.md#L223
https://github.com/google/gson/blob/63ee47cb642c8018e5cddd639aa2be143220ad4b/UserGuide.md#L256

#900 added the method `TypeToken.getParameterized` which should probably now be the preferred way of creating these `TypeToken`s.

Could the documentation please be updated?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.