google / google/grr

ClientFileFinder recursive glob ** behaves differently

Open
#915 0 comments 0 reactions 1 assignee Claimed by @panhania View on GitHub
Dominant language
Python
Stars
5.1k
Forks
796
PR merge metrics
No merged PRs in 30d

Description

Compared to FileFinder, ClientFileFinder's recursive glob `**` shows two regressions:
1. `**` does not match the current directory, only subdirectories. this means that `/foo/**` does not match `/foo/bar` with CilentFileFinder, only `/foo/subfolder/bar`.
* Workaround: Specify two path expressions, `/foo/*` and `/foo/**`.
2. `**suffix` fails in ClientFileFinder with `malformed recursive component`. This means that `/foo/**.ext` fails in ClientFileFinder
* Workaround: Enclose recursive glob in slashes. Use `/foo/**/*.ext` and `/foo/*.ext`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.