google / google/grr

GRR Client Crashes panel (in AdminUI dashboard) does not work as expected

Open
#789 8 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
5.1k
Forks
796
PR merge metrics
No merged PRs in 30d

Description

As mentioned in #787, the [GRR Client Crashes panel](https://github.com/tsehori/grr/blob/b8cd73652f9251f54fe059cebc42ca26bd601184/monitoring/grafana/grr_grafanalib_dashboards/reusable_panels.py#L103), which is a part of the [AdminUI dashboard](https://github.com/tsehori/grr/blob/b8cd73652f9251f54fe059cebc42ca26bd601184/monitoring/grafana/grr_grafanalib_dashboards/dashboards_to_generate/admin_ui.dashboard.py), does the following: when GRR clients are not crashing, the graph shows a flat line. The problem is that, even when GRR clients do crash, the graph remains as a flat line, where we expect to see a "spike" that indicates that something goes wrong.
![Screenshot from 2020-06-24 07-10-39](https://user-images.githubusercontent.com/10086302/85512923-1ca5b380-b603-11ea-8f62-863aa559bebd.png)
I suspect that the issue is not with the query implemented in #787, but that the client crash is not recorded well in the [Prometheus Stats collector](https://github.com/google/grr/blob/b2969c7ed6f5c6e62919fa66625d992e7b5e0b34/grr/server/grr_response_server/prometheus_stats_collector.py#L149).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.