google / google/grr

Pass parameter to specify how long execute binary|hack should run for

Open
#343 2 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
5.1k
Forks
796
PR merge metrics
No merged PRs in 30d

Description

At the moment execute python hack and execute binary on the client will be automatically killed if they take longer than a minute. We've worked around this by having a separate thread call Progress in the python hack itself, but this is a nasty solution.

The ExecuteBinary/PythonHack client actions should take a "timeout" parameter that specifies how long the action is expected to run for. We heartbeat that many seconds into the future.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.