google / google/ground-platform

[Code health] Eliminate global async states in favor of component @Inputs

Open
#2,289 4 comments 0 reactions 1 assignee Claimed by @rfontanarosa View on GitHub
type: code health
Dominant language
TypeScript
Stars
249
Forks
112
Avg merge
10h 7m
Merged PRs (30d)
4

Description

Nested calls to subscribe() in `ngOnInit`, mixing signals + observables, and inconsistent and/or duplicate source-of-truth, and loose separation of concerns have made many of the components hard to grok and maintain. For example:

https://github.com/google/ground-platform/blob/a860c366f330afc9967271e889fb3579d13cefdf/web/src/app/pages/create-survey/create-survey.component.ts#L155-L195

Assigning this task to myself to come up with a plan to improve maintainability across the codebase.

Already done: #2301

@rfontanarosa FYI

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.