google / google/ground-android

[Code health] Design flaw in main startup flow

Open
#2,934 1 comment 0 reactions 0 assignees View on GitHub
type: code health
Dominant language
Kotlin
Stars
293
Forks
149
Avg merge
1d 16h
Merged PRs (30d)
42

Description

Play services and login are tied to an event triggered by `MainViewModel` and handled by `MainActivity`. The `MainActivity` may not be active when this event is triggered, so it will sometimes miss the sign-in event, for example when the app is temporarily in the background (e.g., when Play services are being installed, and when started in the background while debugging from Android Studio).

The initialization flow "evolved" while we were still learning modern Android dev, rather than being thoughtfully designed. @shobhitagarwal1612 @scolsen @anandwana001, any ideas on how this should work in practice?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.