google / google/ground-android

Reuse proto fields in local LOI model

Open
#2,792 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
293
Forks
149
Avg merge
1d 16h
Merged PRs (30d)
42

Description

We set the value of `custom_tag` proto field to `customId` and `source` to `isPredefined` in the local LOI model. Ideally, we should reuse the proto fields in the local model as well.

We started working on this but later realized that it would require writing local db migrations as well since the db column name needs to be renamed as well. Ideally, we should club this change if there are any large breaking changes to prevent the extra effort of writing migrations for code health.

Split from https://github.com/google/ground-android/issues/2717

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.