google / google/ground-android

[Code health] Packing Structure of Unit Test

Open
#2,504 3 comments 0 reactions 0 assignees View on GitHub
type: code health
Dominant language
Kotlin
Stars
293
Forks
149
Avg merge
1d 16h
Merged PRs (30d)
42

Description

Currently, some of the files are there at the parent level of the unit test module, which can be cluttered if increases in the future (As the code grows, the files definitely increase in this area)

This can be fixed by putting each file in their respective packages. This re-structuring will not affect what packaging structure we are following in the main module, as all these are helper classes for testing purpose only.

Suggestion
```md
unitTest/java/com/google/android/ground
├── domain
├── hilt
│ ├── BaseHiltTest
│ └── HiltExt.kt
├── mockito
│ └── MockitoKotlinHelpers.kt
├── model
├── module
│ ├── TestAuthenticationModule
│ ├── TestCoroutineDispatchersModule
│ ├── TestCoroutineScopesModule
│ ├── TestRemoteStorageModule
│ ├── TestWorkManagerModule
│ └── TestLocalDatabaseModule
├── navigation
│ └── NavigationTestHelper.kt
├── persistence
├── repository
├── system
├── ui
├── util
│ └── ResultAssertions.kt
├── view
│ ├── RecyclerViewHelper.kt
│ ├── CustomViewActions
│ └── UiTestHelper.kt
├── MainActivityTest
└── MainViewModelTest
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.