google / google/ground-android

[Code health] Rename `on*` functions

Open
#2,439 3 comments 0 reactions 0 assignees View on GitHub
type: code health
Dominant language
Kotlin
Stars
293
Forks
149
Avg merge
1d 16h
Merged PRs (30d)
42

Description

We have some functions throughout the app that are called `on...Result...` `on...Click...` and similar. These names are really opaque and do not convey anything about the actual behavior that's happening when the function is called. It'd be better to convey semantics in these names instead of intended/current call site use, e.g. `onTakePhoto` --> `startPhotoCapture`, `onSignInButtonClick` --> `attemptUserSignIn` etc.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.