google / google/ground-android
[Code health] Rename `on*` functions
Open
type: code health
- Dominant language
- Kotlin
- Stars
- 293
- Forks
- 149
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 42
Description
We have some functions throughout the app that are called `on...Result...` `on...Click...` and similar. These names are really opaque and do not convey anything about the actual behavior that's happening when the function is called. It'd be better to convey semantics in these names instead of intended/current call site use, e.g. `onTakePhoto` --> `startPhotoCapture`, `onSignInButtonClick` --> `attemptUserSignIn` etc.
Contributor guide
Assessment
This issue has not been assessed yet.