google / google/grinder.dart

File operations aren't Windows-friendly

Open
#345 0 comments 3 reactions 0 assignees View on GitHub
bug
Dominant language
Dart
Stars
266
Forks
36
Avg merge
23h 25m
Merged PRs (30d)
2

Description

It looks like `grinder_files.dart` assumes that each platform has a single path separator that's used uniformly in all paths:

https://github.com/google/grinder.dart/blob/b335e3a40a69548ac05fcfb538c8860a14d0d559/lib/grinder_files.dart#L116-L119

This is not true on Windows, where `\` and `/` may both be used as separators, including within the same path. This leads to bugs where, for example, the `copy()` function can incorrectly include the source file's directory name in the destination path.

I recommend using [the `path` package](https://pub.dev/packages/path) rather than rolling custom path manipulation.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.