google / google/gopacket

pcapgo passing errors as text instead of value

Open
#722 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
6.8k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

pcapgo/capture.go

`readOne` and `ReadPacketData` are passing error as text instead of underlying error value.
As a result `packetsToChannel` in packet.go can't handle (*EthernetHandle).fd closed handle case, falling into infinite loop. This situation leads to goroutine/channel/mem leak.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.