google / google/gopacket

IPv4Defragmenter DiscardOlderThan returns wrong number.

Open
#475 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
6.8k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

According to documentation, DiscardOlderThan() returns the number of FragmentList aka number of fragment packets it has discarded. The actual return value is the total number of the ip flows the derangementer holds in it's flows map, including the flows that was defragmented successfully and was flushed.

Possible solution is deleting an ip flow from the flows map when flushing it, instead of replacing it with a new ip flow.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.