google / google/gopacket

Too many package level constants/variables?

Open
#454 5 comments 1 reaction 0 assignees View on GitHub
Dominant language
Go
Stars
6.8k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

In my opinion, layers package is too polluted with exported constants/variables. Would it be a good idea to have separate package for each layer?
Perhaps all commonly used layers in a single package (_layers_), and all uncommon layers in their own packages? (e.g. _layers/lldp_ package).

This can have an additional advantage of shorter identifier names because then we can drop prefix. For example, _layers.LLDPChassisIDSubType_ will become _lldp.ChassisIDSubType_.

This would be breaking change however.

Any thoughts?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.