google / google/gopacket

decodeTLSRecords should not replace the BaseLayer contents

Open
#1,177 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
6.8k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

Indeed this line should be removed as it is impossible to access the full bytes from Layer to implement TLS Handshake decoding ( which is not implemented ).

https://github.com/google/gopacket/blob/a9779d139771f6a06fc983b18e0efd23ca30222f/layers/tls.go#L138

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.