google / google/gopacket

LLDP Unknown Tlvs are not handled

Open
#1,038 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
6.8k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

Hi Folks,

type LinkLayerDiscoveryInfo struct {
BaseLayer
PortDescription string
SysName string
SysDescription string
SysCapabilities LLDPSysCapabilities
MgmtAddress LLDPMgmtAddress
OrgTLVs []LLDPOrgSpecificTLV // Private TLVs
**Unknown []LinkLayerDiscoveryValue // undecoded TLVs**
}

**Unknown tlv slice is not filled/handled anywhere. Is this something a known issue?

Fix Proposal: Would suggest decodeLinkLayerDiscovery() to have a default switch case next to case LLDPTLVOrgSpecific: at line 897 to populate the Unknown.

Regards,
Mohamed Navas

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.