google / google/googletest

[Bug]: FloatingEqMatcher doesn't work with const float value types

Open
#4,462 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
39.5k
Forks
10.9k
Avg merge
6d 13h
Merged PRs (30d)
1

Description

### Describe the issue

`FloatingEqMatcher` doesn't work with `const` float value types. See https://godbolt.org/z/zexhra9eG. A const conversion is missing

### Steps to reproduce the problem

https://godbolt.org/z/zexhra9eG

### What version of GoogleTest are you using?

trunk

### What operating system and version are you using?

(see godbolt repro)

### What compiler and version are you using?

clang 15

### What build system are you using?

(see godbolt repro)

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with FloatingEqMatcher and reproduce the failure using the linked Godbolt example with clang 15 and the trunk version of GoogleTest. Trace the const float value-type conversion involved and verify that the Godbolt reproduction succeeds after the issue is addressed.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.