google / google/googletest

Death Test on iOS

Open
#2,834 2 comments 1 reaction 1 assignee Claimed by @vslashg View on GitHub
Dominant language
C++
Stars
39.5k
Forks
10.9k
Avg merge
6d 13h
Merged PRs (30d)
1

Description

googletest does not support `EXPECT_DEATH` on iOS platform, see how it tests for `!GTEST_OS_IOS`: https://github.com/google/googletest/blob/0eea2e9fc63461761dea5f2f517bd6af2ca024fa/googletest/include/gtest/internal/gtest-port.h#L592

Recently, I tried to force define `GTEST_HAS_DEATH_TEST` on GSL, see https://github.com/dipidoo/GSL/commit/91858ca3f32c4c7d7704b7ed72043caa451377a3. The tests run normally and successfully https://github.com/dipidoo/GSL/runs/644183147?check_suite_focus=true#step:7:459

If googletest now supports `EXPECT_DEATH` on iOS platform, I could remove the `!GTEST_OS_IOS` check. Let me know.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.