google / google/googletest

Remove testing::internal::posix:: functions in C++11 standard

Open
#2,572 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
39.5k
Forks
10.9k
Avg merge
6d 13h
Merged PRs (30d)
1

Description

Assuming that the C++11 compiler requirement translates into a C++11-compliant standard library as well, I think we can remove some of the functions in `gtest-port.cc`.

* FOpen - std::fopen in ``
* FClose - std::fclose in ``
* FReopen - std::freopen in ``
* StrError - std::strerror in ``
* Abort - std::abort in ``

@gennadiycivil Would you be interested in a PR / CL that removes these functions?

Contributor guide

Open the contributing guide

Research direction

Start in gtest-port.cc and inspect the definitions and references for FOpen, FClose, FReopen, StrError, and Abort. Confirm the corresponding standard-library headers and calls, then verify that the wrappers and their uses are removed without breaking the existing build and tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing-qa
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.