google / google/googletest

Feature request: Change all type names from AX to TArgX

Open
#2,135 7 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
39.5k
Forks
10.9k
Avg merge
6d 13h
Merged PRs (30d)
1

Description

I work with legacy code bases which have hardcoded constants for A0, A1, etc (unavoidable). To use gtest, I replace all template arguments A0, A1, ... A10 with TArg0, TArg1, etc.

This is no fault of Google test, but I was wondering if it would be possible for you to make this change in the gtest code base. I believe it would help others working with legacy code bases with hardcoded constants too, especially with common names like A1, etc. I'm happy to make this change myself and open a PR, with the gtest team's approval.

As a side note, I also have to do this kind of search-replace on the protobuf source code, where I replace NAME with GNAME and MAX_TYPE with GMAX_TYPE.

Thanks!

Contributor guide

Open the contributing guide

Research direction

Start by locating the gtest template arguments named A0 through A10 and identify every affected part of the gtest codebase. Review the existing tests before changing names; done means the requested arguments consistently use TArg0 through TArg10 and the test suite still passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.