google / google/googletest

Added special catch for std::exception in GTEST_TEST_NO_THROW reverted?

Open
#2,071 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
39.5k
Forks
10.9k
Avg merge
6d 13h
Merged PRs (30d)
1

Description

We noticed when using EXPECT_NO_THROW that we just see "Actual: it throws." when it throws, we would like to see what was actually thrown. (We are currently on 1.8.0).

Looking at the git log it seems that there has been a fix for this on master: 0354ccb049ea2b9e4696adb8b5a013287daf0c33

But in a later commit that is reverted again, however that commit message is "support printing std::reference_wrapper in gUnit" which does not mention any changes to EXPECT_NO_THROW: 1b20bd176fb3bc6feef4ab17488a2ac8850f42dd

Based on the commit message the revert seem to be a mistake? If not, why was it reverted?

Contributor guide

Open the contributing guide

Research direction

Start with the EXPECT_NO_THROW behavior described in the issue and compare commits 0354ccb049ea2b9e4696adb8b5a013287daf0c33 and 1b20bd176fb3bc6feef4ab17488a2ac8850f42dd. Check the relevant implementation and tests to determine whether the std::exception reporting change was intentionally reverted. Done means documenting the reason or confirming the regression with a focused test.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.