google / google/googlesql

ResolvedNodes.ResolvedTableScan shouldn't require forSystemTimeExpr to be not null

Open
#32 4 comments 2 reactions 1 assignee Claimed by @matthewcbrown View on GitHub
Dominant language
C++
Stars
2.6k
Forks
260
PR merge metrics
No merged PRs in 30d

Description

Generated code validates that `forSystemTimeExpr` isn't null:

```java
protected void validate() {
super.validate();
Preconditions.checkArgument(this.table != null, "table must be set");
Preconditions.checkArgument(this.forSystemTimeExpr != null, "forSystemTimeExpr must be set");
Preconditions.checkArgument(this.alias != null, "alias must be set");
}
```

While `NULL` is a valid case if system time functionality isn't used.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.