google / google/googlesql

Can't build on linux/aarch64

Open
#112 7 comments 9 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.6k
Forks
260
PR merge metrics
No merged PRs in 30d

Description

I'm one of those horrible M1 Mac users screwing up the buildchain for every open source projects. So let me begin by thanking you for abstracting macos/darwin builds so they're architecture independent. It would be great if we could do the same for Linux.

Things work fine in MacOS. It gets _interesting_ when we involve Docker.

Containers can be built for multiple architectures (e.g. x86_64 & aarch64). Docker can run either architecture, though it prefers the native architecture of the host machine. So if an ARM/aarch64 mac tries to build zetasql inside a (local default) aarch64 container, it'll fail, as linux-specific builds are tied to:

`"@bazel_tools//src/conditions:linux_x86_64"`

While mac/darwin builds are configured to use:

`"@bazel_tools//src/conditions:darwin"` or `"@platforms//os:macos"`

It would be nice if linux builds could be configured independent of cpu architecture, or at least could select for linux_aarch64.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.