google / google/google-toolbox-for-mac

Include path to gtest.h in GTMGoogleTestRunner.mm

Open
#407 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Objective-C
Stars
1.2k
Forks
278
Avg merge
6h 55m
Merged PRs (30d)
4

Description

[UnitTesting/GTMGoogleTestRunner.mm](https://github.com/google/google-toolbox-for-mac/blob/main/UnitTesting/GTMGoogleTestRunner.mm) has the following code to include `gtest.h`.

```
#include "third_party/gtest/include/gtest/gtest.h"
```

However, the actual path is `(third_party/googletest/)googletest/include/gtest/gtest.h`.

Would you change the include path to either of the following paths?

```
#include "third_party/gtest/googletest/include/gtest/gtest.h"
```

or

```
#include "third_party/googletest/googletest/include/gtest/gtest.h"
```

FYI. [google/mozc](https://github.com/google/mozc/) is the project that needs this change.
https://github.com/google/mozc/blob/master/src/WORKSPACE.bazel#L142

Thank you!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.