google / google/google-java-format

document/explain logic of ignoring --lines

Open
#1,276 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Java
Stars
6.2k
Forks
937
Avg merge
6m
Merged PRs (30d)
3

Description

as seen in #942 and #1000 (and others) use of `--lines` does not reliably work.

I'm trying to grok how/why....

As an example:

```hello.java
///usr/bin/env jbang "$0" "$@" ; exit $?

import static java.lang.System.*;

public class hello {

public static void main(String... args) {
out.println("Hello World");
}
}
```

I want google java format to ignore the first line - reading other isseues I should --skip-* as much as possible ...

`jbang com.google.googlejavaformat:google-java-format:1.28.0 --lines 2:9999 --skip-javadoc-formatting --skip-reflowing-long-strings --skip-sorting-imports --skip-removing-unused-imports hello.java`

result in first line being formatted as: `/// usr/bin/env jbang "$0" "$@" ; exit $?`

why ?

If I add `--lines 1000:9999` it works...but now the code is not formatted at all.

is this really the intended behavior of --lines ?

any way to have it not try include outside the lines requested?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.