google / google/google-authenticator-libpam

Generate QR code locally using JS or something if qrencode is not available

Open
#32 7 comments 1 reaction 0 assignees View on GitHub
enhancement
Dominant language
C
Stars
2k
Forks
305
PR merge metrics
No merged PRs in 30d

Description

_From @ThomasHabets on October 10, 2014 8:6_

Original [issue 216](https://code.google.com/p/google-authenticator/issues/detail?id=216) created by contact@markcunningham.ie on 2012-10-11T19:04:00.000Z:

When you run the google-authticator it generates a url that you pop in your browser let's say it was http://example.com/bla?code=foo, even though it's google's servers you're still sending it to their servers which may or may not be wanted by most users.

I realise you guys want to make use of your google graph engine however many people won't be happy with sending all their secret keys to google.

Instead of providing a url that sends the secret code to googles servers, why not use javascript to generate the QR code and put the secret value in a hash value such as
http://example.com/qr#mysupersecretkeyhere
so the javascript pulls it out and generates the qr code and it doesn't get sent over the network. I hacked together a version of this from some public javascript qr scripts that shouldn't be too hard to find/write.

_Copied from original issue: google/google-authenticator#215_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.