google / google/google-authenticator-libpam

grace_period doesn't honor forward_pass

Open
#181 11 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
2k
Forks
305
PR merge metrics
No merged PRs in 30d

Description

I was trying to implement `grace_period` with our existing `forward_pass` option to no avail. While `grace_period` itself authenticates without issue with the `LASTIP` option, I believe the full password gets forwarded without being trimmed (see https://github.com/google/google-authenticator-libpam/blob/master/src/pam_google_authenticator.c#L1888 and https://github.com/google/google-authenticator-libpam/blob/master/src/pam_google_authenticator.c#L1923-L1926) which causes the behaviour of `forward_pass` to behave differently.

Was wondering if my suspicion is correct and if so, could someone help with the bug fix?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.