google / google/googet

oswrap package is mostly redundant

Open
#133 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
101
Forks
51
Avg merge
17h 1m
Merged PRs (30d)
4

Description

The majority of the [oswrap](https://github.com/google/googet/tree/master/oswrap) package is thin wrappers around functions from the standard os package, with an extra path-normalization step to handle extended-length paths on Windows. But https://github.com/golang/go/issues/21782 and https://github.com/golang/go/issues/20829 indicate that go now natively handles extended-length paths on Windows. See [fixLongPath](https://github.com/golang/go/blob/598df45fceb6e10d643ed0c07a3df80cffd507f1/src/os/path_windows.go#L50). So I strongly suspect that most of oswrap (with the possible exception of RemoveOnReboot) is no longer needed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.