google / google/go-tpm

Possible Typo in TPMUAsymScheme Method?

Open
#389 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
673
Forks
188
PR merge metrics
No merged PRs in 30d

Description

Should this line be `u.selector == TPMAlgECDH`, like all the other methods?

https://github.com/google/go-tpm/blob/f37a5cab945313cd9e6276a7385145ebbaf5e2bd/tpm2/structures.go#L2358

Contributor guide

Open the contributing guide

Research direction

Open tpm2/structures.go at line 2358 and compare TPMUAsymScheme with the surrounding methods. Confirm whether the selector should use TPMAlgECDH as described; done means the method is consistent with the other methods and the relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cryptography, security
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.