google / google/go-tpm

Use `crypto/ecdh` for tpmdirect

Open
#327 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
673
Forks
188
PR merge metrics
No merged PRs in 30d

Description

It seems like `tpmdirect` is dealing with a bit of low-level stuff to accomplish ECDH which is mostly solved with the new `crypto/ecdh` package.

Would it be a good idea to consider using this package maybe?

Currently the only missing part is `TPMECCNistP224` which `crypot/ecdh` doesn't implement.

Contributor guide

Open the contributing guide

Research direction

Start by locating tpmdirect's low-level ECDH implementation and comparing it with Go's crypto/ecdh package. Check how the missing TPMECCNistP224 case affects the proposed change; done means tpmdirect uses the standard package where supported without losing required TPM curve support.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cryptography
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.