google / google/go-tpm

Only signing schemes are settable on TPMS_RSA_PARMS

Open
#244 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
673
Forks
188
PR merge metrics
No merged PRs in 30d

Description

https://github.com/google/go-tpm/blob/d3310770bfec97b19d08524b63c458c3487d0d93/tpm2/structures.go#L204-L210

Instead of `Sign *SigScheme`, we should have something that reflects `TPMT_RSA_SCHEME` (which can be a signing or decryption scheme).

Contributor guide

Open the contributing guide

Research direction

Start at tpm2/structures.go lines 204-210 and compare TPMS_RSA_PARMS with the TPMT_RSA_SCHEME representation referenced in the issue. Search for usages of the Sign field and related scheme types before updating the structure. Done means TPMS_RSA_PARMS can represent both signing and decryption schemes consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
security
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.