TPM2 Quote takes an Algorithm where it should take a Scheme
Open
- Dominant language
- Go
- Stars
- 673
- Forks
- 188
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/google/go-tpm/blob/ac5b427c06a867a3f94077b406507ec93f1e04e1/tpm2/tpm2.go#L936
The last parameter, `sigAlg`, is an `Algorithm` which corresponds to `TPM_ALG` in the spec, but it should be some type that corresponds to `TPMT_SIG_SCHEME` in the spec. As written, the only parameter that can be passed to `Quote` successfully is `AlgNull` (meaning you have to set the scheme on the AK when you create it).
This is what the test does:
https://github.com/google/go-tpm/blob/ac5b427c06a867a3f94077b406507ec93f1e04e1/tpm2/test/tpm2_test.go#L1258-L1279
Contributor guide
Assessment
This issue has not been assessed yet.