google / google/go-tpm-tools

GetGCEInstanceInfo should return error if not found

Open
#323 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
309
Forks
118
Avg merge
1d 16h
Merged PRs (30d)
33

Description

`GetGCEInstanceInfo` return `nil,nil` in certain circumstances:

https://github.com/google/go-tpm-tools/blob/master/server/verify.go#L208-L211

shoudn't these `return nil, fmt.Errorf("...")`

Contributor guide

Open the contributing guide

Research direction

Start at the GetGCEInstanceInfo entry point in server/verify.go around lines 208-211 and inspect the circumstances that currently return nil,nil. Confirm the expected not-found behavior and error wording from nearby code. Done means the function returns a non-nil error instead of nil,nil for that case, with the relevant tests passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
security
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.