google / google/go-jsonnet

go-jsonnet windows version is not compatible with grafonnet

Open
#786 3 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Go
Stars
1.8k
Forks
263
PR merge metrics
No merged PRs in 30d

Description

Until v0.20.0, go-jsonnet windows x86-64 does not support blank line within |||. e.g.

[annotation.libsonnet](https://github.com/grafana/grafonnet/blob/main/gen/grafonnet-v10.0.0/custom/dashboard/annotation.libsonnet)

```
'#withAnnotations':
d.func.new(
|||
`withAnnotations` adds an array of annotations to a dashboard.

This function appends passed data to existing values
|||,
args=[d.arg('value', d.T.array)]
),
```

will result in Text block not terminated with |||

This makes it imcompatible with grafonnet.

It seems this problem has been raised long time ago, but it seems still a problem on windows.
[Allow empty lines in multi-line blocks](https://github.com/google/jsonnet/issues/82)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.