google / google/go-jsonnet

escapeStringXml vs escapeStringXML

Open
#743 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
1.8k
Forks
263
PR merge metrics
No merged PRs in 30d

Description

The PR [[fix661]](https://github.com/google/go-jsonnet/pull/662) that added support for the escapeStringXml() function named it with XML in uppercase, i.e. escapeStringXML().

According to the Stdlib [reference](https://jsonnet.org/ref/stdlib.html#:~:text=std.-,escapeStringXml,-(str)), it should be the former.

I don't know which one is correct (I assume the former for consistency with the other escapeString* functions), but the documentation and the implementation need to be consistent.

Or overload them so both forms work.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.