google / google/go-dap

Do not use json.RawMessage for untyped request arguments

Open
#90 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
140
Forks
29
PR merge metrics
No merged PRs in 30d

Description

Using `json.RawMessage` for _request_ arguments makes the users of `go-dap` unnecessary cumbersome. `any` would be a better choice. Compare

```
msg, err := json.Marshal(someArgs)
if err != nil {
....
}
AttachRequest {
Arguments: json.RawMessage(msg),
}
```
and
```
AttachRequest {
Arguments: someArgs,
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.