google / google/go-containerregistry

Optimize estargz.ReadCloser to not buffer

Open
#876 0 comments 0 reactions 0 assignees View on GitHub
lifecycle/frozen
Dominant language
Go
Stars
4k
Forks
686
Avg merge
2d 12h
Merged PRs (30d)
26

Description

This is to track [this discussion](https://github.com/google/go-containerregistry/pull/870#discussion_r545241334) (and the underlying issue), which is that to provide the `estargz.Build` interface what it needs we are currently buffer the layer into memory.

We should discuss with the estargz folks whether they *actually* need an `io.SectionReader`, or can be more explicit about the interface they require (which `io.SectionReader` implements). Ideally we could narrow this interface to something that `os.File` *also* implements, but without a standard "length" mechanism that may be hard 🤔

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.